Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): add actionItem to beta #497

Merged
merged 12 commits into from
Jun 28, 2023

Conversation

atnagata
Copy link
Contributor

@atnagata atnagata commented Jun 9, 2023

@atnagata atnagata requested a review from KaWaite as a code owner June 9, 2023 02:18
@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 45f1a3a
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/649bb9cb912b320008cfe274
😎 Deploy Preview https://deploy-preview-497--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #497 (45f1a3a) into main (3a12f5f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #497      +/-   ##
==========================================
- Coverage   26.66%   26.66%   -0.01%     
==========================================
  Files        1339     1340       +1     
  Lines      144591   144638      +47     
  Branches     3483     3484       +1     
==========================================
  Hits        38561    38561              
- Misses     104908   104955      +47     
  Partials     1122     1122              
Flag Coverage Δ
web 23.99% <0.00%> (-0.01%) ⬇️
web-beta 23.99% <0.00%> (-0.01%) ⬇️
web-classic 23.99% <0.00%> (-0.01%) ⬇️
web-utils 23.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/beta/components/ActionItem/index.tsx 0.00% <0.00%> (ø)

The square icon will be visible after you merge the "StorytellingPageSectionItem".
In my opinion, I didn't add a square here either because adding it to icons would cause conflicts.
@pyshx pyshx changed the title Chore(web): Add ActionItem chore(web): add actionItem to beta Jun 9, 2023
@keiya01
Copy link
Member

keiya01 commented Jun 19, 2023

Please fix multiple lines as well.
Screenshot 2023-06-19 at 16 01 37

@KaWaite KaWaite merged commit d48d549 into reearth:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants